Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for end-of-life node versions #1049

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/npm-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
submodules: recursive
- uses: actions/setup-node@v3
with:
node-version: 18
node-version: 20
registry-url: https://registry.npmjs.org/
cache: "npm"
- run: npm ci
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
build:
strategy:
matrix:
node: [10, 12, 14, 16, 18, 20]
node: [16, 18, 20, 21]
os: [ubuntu-22.04]
include:
# single mac test due to minute multipliers
Expand Down Expand Up @@ -39,5 +39,5 @@ jobs:
run: npm ci
# skipping on windows for now due to Make / mocha exit code issues
- name: Test
if: runner.os != 'Windows' && matrix.node != 10
if: runner.os != 'Windows'
run: npm test
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ Steps to update:
```
Note: This is ran automatically during CI flows but it's good to run it during the version upgrade pull request.

1. Run `npm install --lockfile-version 2` to build with the new version and fix any build errors that occur.
1. Run `npm install` to build with the new version and fix any build errors that occur.

1. Run unit tests: `npm run test`

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Play nice; Play fair.
## Requirements

* Apache Kafka >=0.9
* Node.js >=4
* Node.js >=16
* Linux/Mac
* Windows?! See below
* OpenSSL
Expand Down
Loading
Loading