Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to librdkafka 2.3.0 #1047

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Update to librdkafka 2.3.0 #1047

merged 4 commits into from
Oct 26, 2023

Conversation

riley-pikus
Copy link
Contributor

@GaryWilber
Copy link
Collaborator

GaryWilber commented Oct 26, 2023

@riley-pikus Thanks for the PR. Could you delete and recreate the package-lock.json file by running npm install --lockfile-version 2. The build checks failed, likely due to an compat issue in older node/npm releases. Sticking with lock file v2 might fix it.
Edit: Never mind, I managed to commit the change 😄

@riley-pikus
Copy link
Contributor Author

@riley-pikus Thanks for the PR. Could you delete and recreate the package-lock.json file by running npm install --lockfile-version 2. The build checks failed, likely due to an compat issue in older node/npm releases. Sticking with lock file v2 might fix it.

I was in the middle of doing this locally but it looks like you beat me to it 😀. Want me to update the CONTRIBUTING.md? There is also step 6 of running e2e tests but that command doesn't exist within package.json

@GaryWilber
Copy link
Collaborator

@riley-pikus Thanks for the PR. Could you delete and recreate the package-lock.json file by running npm install --lockfile-version 2. The build checks failed, likely due to an compat issue in older node/npm releases. Sticking with lock file v2 might fix it.

I was in the middle of doing this locally but it looks like you beat me to it 😀. Want me to update the CONTRIBUTING.md? There is also step 6 of running e2e tests but that command doesn't exist within package.json

Yea could you update that. I will make a PR to release v2.18.0 of this package after this is merged in. Thanks

@riley-pikus
Copy link
Contributor Author

@riley-pikus Thanks for the PR. Could you delete and recreate the package-lock.json file by running npm install --lockfile-version 2. The build checks failed, likely due to an compat issue in older node/npm releases. Sticking with lock file v2 might fix it.

I was in the middle of doing this locally but it looks like you beat me to it 😀. Want me to update the CONTRIBUTING.md? There is also step 6 of running e2e tests but that command doesn't exist within package.json

Yea could you update that. I will make a PR to release v2.18.0 of this package after this is merged in. Thanks

Done, appreciate the quick turn around on this release @GaryWilber!

@GaryWilber GaryWilber merged commit 2b7b1bd into Blizzard:master Oct 26, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants