Renamed time caching functions

CHANGELOG.md

@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Updated
+- Renamed time caching functions
+
 ### Fixed
 - Better GTFS export for currency
 

src/lib/import-gtfs.ts

@@ -61,18 +61,18 @@ interface Dictionary<T> {
 }
 type Tuple = [seconds: number | null, date: string | null];
 
-const dateCache: Dictionary<Tuple> = {};
+const timeCache: Dictionary<Tuple> = {};
 
-const calculateAndCacheDate = (value: string): Tuple => {
-  const cached = dateCache[value];
-  if (cached != null) {
+const formatAndCacheTime = (value: string): Tuple => {
+  const cached = timeCache[value];
+  if (cached !== undefined) {
     return cached;
   }
 
-  const seconds = calculateSecondsFromMidnight(value);
-  const date = padLeadingZeros(value);
-  const computed: Tuple = [seconds, date];
-  dateCache[value] = computed;
+  const timeAsSecondsFromMidnight = calculateSecondsFromMidnight(value);
+  const timeAsString = padLeadingZeros(value);
+  const computed: Tuple = [timeAsSecondsFromMidnight, timeAsString];
+  timeCache[value] = computed;
   return computed;
 };
 
@@ -304,9 +304,10 @@ const formatGtfsLine = (
   for (const [timeColumnName, timestampColumnName] of TIME_COLUMN_PAIRS) {
     const value = formattedLine[timeColumnName];
     if (value) {
-      const [seconds, date] = calculateAndCacheDate(value);
-      formattedLine[timestampColumnName] = seconds;
-      formattedLine[timeColumnName] = date;
+      const [timeAsSecondsFromMidnight, timeAsString] =
+        formatAndCacheTime(value);
+      formattedLine[timestampColumnName] = timeAsSecondsFromMidnight;
+      formattedLine[timeColumnName] = timeAsString;
     }
   }