Fix: fail early if definitions contains non-existent dir #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the configuration file explicitly lists paths for CMake definitions, gersemi should fail early if one of them does not exist. Otherwise, problems (like typos) with these paths may be detected only later - especially when using gersemi as pre-commit hook. Co-Authored-By: Blank Spruce <32396809+BlankSpruce@users.noreply.github.com>
BlankSpruce
force-pushed
the
fail-early-if-definitions-contains-nonexisten-dir
branch
2 times, most recently
from
83df535 to
c824823
Compare
BlankSpruce
force-pushed
the
fail-early-if-definitions-contains-nonexisten-dir
branch
from
c824823 to
01df622
Compare
|
Nice change. I've added a couple of things:
You're still main author of the first commit. I'll release it as 0.15.1 today. Thank you for your contribution. |
Very nice, thanks! This is of course even much better than my "trivial change"... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the configuration file explicitly lists directories for CMake definitions, gersemi should fail early if one of them does not exist. Otherwise, problems (like typos) with these directories may be detected only later - especially when using gersemi as pre-commit hook.