Meaningless target_link_libraries should be valid code, fixes #13

BlankSpruce · Dec 22, 2023 · 96e25a1 · 96e25a1
1 parent 9757ede
commit 96e25a1
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,14 @@
 # Changelog
 
+## [0.10.0] 2023-12-22
+### Added
+- configuration schema that can be used with yaml LSP server, see: [JSON Schema](https://json-schema.org/) and #12
+- yaml header linking to configuration schema in configuration produced by `--default-config`
+- support for Python 3.12
+
+### Fixed
+- meaningless but syntactically valid `target_link_libraries` with just library name won't crash gersemi
+
 ## [0.9.4] 2023-12-17
 ### Added
 - support for new keywords in native commands available in CMake 3.28

diff --git a/README.md b/README.md
@@ -71,7 +71,7 @@ You can use gersemi with a pre-commit hook by adding the following to `.pre-comm
 ```yaml
 repos:
 - repo: https://github.com/BlankSpruce/gersemi
-  rev: 0.9.4
+  rev: 0.10.0
   hooks:
   - id: gersemi
 ```

diff --git a/gersemi/__version__.py b/gersemi/__version__.py
@@ -4,4 +4,4 @@
 __license__ = "MPL 2.0"
 __title__ = "gersemi"
 __url__ = "https://github.com/BlankSpruce/gersemi"
-__version__ = "0.9.4"
+__version__ = "0.10.0"
diff --git a/gersemi/command_invocation_dumpers/target_link_libraries_command_dumper.py b/gersemi/command_invocation_dumpers/target_link_libraries_command_dumper.py
@@ -12,6 +12,9 @@ class IsolateConfigurationTypeAndItem(Transformer_InPlace):
 
     def arguments(self, children):
         new_children = []
+        if len(children) < 2:
+            return Tree("arguments", new_children)
+
         iterator = zip(children, children[1:])
         is_one_of_defined_keywords = is_one_of_keywords(self.keywords)
         for one_behind, current in iterator:

diff --git a/tests/formatter/issue_0013_meaningless_target_link_libraries_should_be_valid_code.in.cmake b/tests/formatter/issue_0013_meaningless_target_link_libraries_should_be_valid_code.in.cmake
@@ -0,0 +1 @@
+target_link_libraries(foo)
diff --git a/tests/formatter/issue_0013_meaningless_target_link_libraries_should_be_valid_code.out.cmake b/tests/formatter/issue_0013_meaningless_target_link_libraries_should_be_valid_code.out.cmake
@@ -0,0 +1 @@
+target_link_libraries(foo)