-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added argument functionality #14
Conversation
Hey @Blank1611 I finished the PR request, let me know if you want any changes implemented ie. making something not required that is. I've also included argparse in the requirements.txt file as thats the library that allows argument parsing in Python |
Hi @MLJBrackett , Sure thanks for the help, Review might take some time, I will try to do as much I can today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have suggested some changes, please go through those.
Let me know if you want to discuss something or need some help.
Thanks for the improvements, they're really good, Ill try and fix them as soon as possible. |
@Blank1611 I resolved all the suggestions that you made, take a look at my commit 8247f6a and tell me what you think. The latest commit just contains pylint fixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more changes to be made, then we are good to go
Hello @Blank1611, I have updated the parameters for the function. I believe this fixes and implements the issue. Thanks for reviewing my code, I have learnt a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers !!
Added argument parsing functionality & removed need for user input when program runs. Also included argparse dependency into requirements folder.
Implements #1