Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added argument functionality #14

Merged
merged 6 commits into from
Oct 30, 2020
Merged

added argument functionality #14

merged 6 commits into from
Oct 30, 2020

Conversation

MLJBrackett
Copy link
Contributor

Added argument parsing functionality & removed need for user input when program runs. Also included argparse dependency into requirements folder.

Implements #1

@MLJBrackett
Copy link
Contributor Author

Hey @Blank1611 I finished the PR request, let me know if you want any changes implemented ie. making something not required that is.

I've also included argparse in the requirements.txt file as thats the library that allows argument parsing in Python

@Blank1611
Copy link
Owner

Hi @MLJBrackett , Sure thanks for the help, Review might take some time, I will try to do as much I can today

@Blank1611 Blank1611 linked an issue Oct 23, 2020 that may be closed by this pull request
Copy link
Owner

@Blank1611 Blank1611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have suggested some changes, please go through those.
Let me know if you want to discuss something or need some help.

jsonmerge_utils.py Outdated Show resolved Hide resolved
jsonmerge_utils.py Outdated Show resolved Hide resolved
jsonmerge_utils.py Outdated Show resolved Hide resolved
jsonmerge_utils.py Outdated Show resolved Hide resolved
jsonmerge_utils.py Outdated Show resolved Hide resolved
jsonmerge_utils.py Outdated Show resolved Hide resolved
jsonmerge_utils.py Outdated Show resolved Hide resolved
jsonmerge_utils.py Outdated Show resolved Hide resolved
jsonmerge_utils.py Outdated Show resolved Hide resolved
jsonmerge_utils.py Outdated Show resolved Hide resolved
@MLJBrackett
Copy link
Contributor Author

Thanks for the improvements, they're really good, Ill try and fix them as soon as possible.

@MLJBrackett
Copy link
Contributor Author

MLJBrackett commented Oct 23, 2020

@Blank1611 I resolved all the suggestions that you made, take a look at my commit 8247f6a and tell me what you think.

The latest commit just contains pylint fixes.

Copy link
Owner

@Blank1611 Blank1611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more changes to be made, then we are good to go

jsonmerge_utils.py Outdated Show resolved Hide resolved
jsonmerge_utils.py Outdated Show resolved Hide resolved
jsonmerge_utils.py Outdated Show resolved Hide resolved
@Blank1611 Blank1611 added feature New feature or request good first issue/beginners Good for newcomers and removed good first issue/beginners Good for newcomers labels Oct 24, 2020
@Blank1611 Blank1611 added this to the Redesign milestone Oct 24, 2020
@MLJBrackett
Copy link
Contributor Author

Hello @Blank1611, I have updated the parameters for the function. I believe this fixes and implements the issue.

Thanks for reviewing my code, I have learnt a lot!

Copy link
Owner

@Blank1611 Blank1611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers !!

@Blank1611 Blank1611 merged commit e785c42 into Blank1611:master Oct 30, 2020
@Blank1611 Blank1611 mentioned this pull request Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add arg parsing, remove input()
2 participants