Merge pull request qmk#156 from lalalademaxiya1/keychron_hc595_driver…

…_fix Updated matrix.c of some boards
Bladehawke · Aug 5, 2023 · af8d6b4 · af8d6b4
2 parents c7d1774 + 4832cd3
commit af8d6b4
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 7 deletions.
diff --git a/keyboards/keychron/k12_pro/matrix.c b/keyboards/keychron/k12_pro/matrix.c
@@ -53,7 +53,7 @@ static void HC595_output(uint16_t data) {
     uint8_t n = 1;
     uint8_t i;
 
-    for (i = 1; i < (MATRIX_COLS - DIRECT_COL_NUM); i++) {
+    for (i = 0; i < (MATRIX_COLS - DIRECT_COL_NUM); i++) {
         writePinLow(HC595_SHCP);
         if (data & 0x1) {
             writePinHigh(HC595_DS);

diff --git a/keyboards/keychron/k1_pro/matrix.c b/keyboards/keychron/k1_pro/matrix.c
@@ -53,7 +53,7 @@ static void HC595_output(uint16_t data) {
     uint8_t n = 1;
     uint8_t i;
 
-    for (i = 1; i < (MATRIX_COLS - DIRECT_COL_NUM); i++) {
+    for (i = 0; i < (MATRIX_COLS - DIRECT_COL_NUM); i++) {
         writePinLow(HC595_SHCP);
         if (data & 0x1) {
             writePinHigh(HC595_DS);

diff --git a/keyboards/keychron/q2_pro/matrix.c b/keyboards/keychron/q2_pro/matrix.c
@@ -53,7 +53,7 @@ static void HC595_output(uint16_t data) {
     uint8_t i;
     uint8_t n = 1;
 
-    for (i = 1; i < (MATRIX_COLS - DIRECT_COL_NUM); i++) {
+    for (i = 0; i < (MATRIX_COLS - DIRECT_COL_NUM); i++) {
         writePinLow(HC595_SHCP);
         if (data & 0x1) {
             writePinHigh(HC595_DS);

diff --git a/keyboards/keychron/q3_pro/matrix_v2.c b/keyboards/keychron/q3_pro/matrix_v2.c
@@ -53,7 +53,7 @@ static void HC595_output(uint16_t data) {
     uint8_t n = 1;
     uint8_t i;
 
-    for (i = 1; i < (MATRIX_COLS - DIRECT_COL_NUM); i++) {
+    for (i = 0; i < (MATRIX_COLS - DIRECT_COL_NUM); i++) {
         writePinLow(HC595_SHCP);
         if (data & 0x1) {
             writePinHigh(HC595_DS);

diff --git a/keyboards/keychron/q4_pro/matrix.c b/keyboards/keychron/q4_pro/matrix.c
@@ -53,7 +53,7 @@ static void HC595_output(uint16_t data) {
     uint8_t n = 1;
     uint8_t i;
 
-    for (i = 1; i < (MATRIX_COLS - DIRECT_COL_NUM); i++) {
+    for (i = 0; i < (MATRIX_COLS - DIRECT_COL_NUM); i++) {
         writePinLow(HC595_SHCP);
         if (data & 0x1) {
             writePinHigh(HC595_DS);

diff --git a/keyboards/keychron/q5_pro/matrix.c b/keyboards/keychron/q5_pro/matrix.c
@@ -53,7 +53,7 @@ static void HC595_output(uint32_t data) {
     uint8_t i;
     uint8_t n = 1;
 
-    for (i = 1; i < (MATRIX_COLS - DIRECT_COL_NUM); i++) {
+    for (i = 0; i < (MATRIX_COLS - DIRECT_COL_NUM); i++) {
         writePinLow(HC595_SHCP);
         if (data & 0x1) {
             writePinHigh(HC595_DS);

diff --git a/keyboards/keychron/q8_pro/matrix.c b/keyboards/keychron/q8_pro/matrix.c
@@ -53,7 +53,7 @@ static void HC595_output(uint16_t data) {
     uint8_t i;
     uint8_t n = 1;
 
-    for (i = 1; i < (MATRIX_COLS - DIRECT_COL_NUM); i++) {
+    for (i = 0; i < (MATRIX_COLS - DIRECT_COL_NUM); i++) {
         writePinLow(HC595_SHCP);
         if (data & 0x1) {
             writePinHigh(HC595_DS);