Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usages of import * from crypto #779

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

tylerlevine
Copy link
Contributor

This avoid an unwanted deprecation notice.

See nodejs/node#23203 for more details.

Ticket: BG-22502

This avoid an unwanted deprecation notice.

See nodejs/node#23203 for more details.

Ticket: BG-22502
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@c12cb6b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #779   +/-   ##
=========================================
  Coverage          ?   61.67%           
=========================================
  Files             ?       89           
  Lines             ?     9210           
  Branches          ?     1811           
=========================================
  Hits              ?     5680           
  Misses            ?     2749           
  Partials          ?      781           
Flag Coverage Δ
#integration 35.03% <ø> (?)
#unit 56.69% <ø> (?)
Impacted Files Coverage Δ
src/v2/coins/rmg.ts 55.62% <0.00%> (ø)
src/keychains.ts 31.96% <0.00%> (ø)
src/v2/trading/tradingAccount.ts 98.21% <0.00%> (ø)
src/v2/coins/xrp.ts 68.25% <0.00%> (ø)
src/v2/internal/internal.ts 62.50% <0.00%> (ø)
src/config.ts 88.00% <0.00%> (ø)
src/v2/coins/ofcToken.ts 87.23% <0.00%> (ø)
src/v2/baseCoin.ts 87.21% <0.00%> (ø)
src/markets.ts 31.57% <0.00%> (ø)
src/prova.ts 71.42% <0.00%> (ø)
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c12cb6b...9d00a25. Read the comment docs.

@tylerlevine tylerlevine merged commit f362c50 into master Jul 1, 2020
@0xabrarhussain 0xabrarhussain deleted the BG-22502-fix-deprecation-warnings branch October 14, 2021 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants