feat(sdk-coin-icp): added address creation and validation logic #5390
Conversation
modules/sdk-coin-icp/src/icp.ts
Outdated
| const payload = { | ||
| network_identifier: utils.getNetworkIdentifier(), | ||
| public_key: { | ||
| hex_bytes: HexEncodedPublicKey, | ||
| curve_type: utils.getCurveType(), | ||
| }, | ||
| }; | ||
|
|
||
| return this.callRosettaApi('/construction/derive', payload); |
There was a problem hiding this comment.
we should not rely on an external API for this
There was a problem hiding this comment.
we have tried to eliminate this API and have this logic locally but the script is not working as expected therefore we are using an API for this and it will not be an external API call because we will be hosting the rosetta node in our environment through which we will be interacting the ICP chain for the details and transactions
cc: @DinshawKothari @darklrd
There was a problem hiding this comment.
it doesn't matter who is hosting the node, the SDK should do these kinds of basic operations locally
There was a problem hiding this comment.
@mohd-kashif So the SDK (client) has to trust BitGo for this address? Also are we sure this function will not be used in OVC in any way?
There was a problem hiding this comment.
@OttoAllmendinger @saravanan7mani ICP is different kind of chain where the interaction with the chain can be done through Rosetta node. We have tried to do the sandboxing with the local methods and not using the rosetta node but it was not a successful attempt as the documentation for the direct interaction with the ICP chain is very limited. The ICP foundation has also recommended us to use the Rosetta node setup.
We have published the TDD for this integration and consulted devops team as well for the same
Advantage for using rosetta node is also that rosetta can also be used for interacting with other chains as well which are in the roadmaps as well
for Rosetta documentation kindly go through the below links
If you guys have any further doubts or want to discuss we can have a call together with other folks as well for better understanding
mohd-kashif
force-pushed
the
WIN-4247
branch
2 times, most recently
from
38ee515 to
1b0e289
Compare
TICKET: WIN-4247