Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin compilation #261

Closed
wants to merge 3 commits into from
Closed

Fix plugin compilation #261

wants to merge 3 commits into from

Conversation

GumpacG
Copy link

@GumpacG GumpacG commented Apr 25, 2023

Description

Fixed the build due to upstream refactors. Gradle version update reference: FasterXML/jackson-core#955 (comment)

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
@GumpacG GumpacG requested a review from a team April 25, 2023 17:51
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #261 (c7003d5) into integ-fix-build (4522422) will not change coverage.
The diff coverage is 100.00%.

@@                Coverage Diff                 @@
##             integ-fix-build     #261   +/-   ##
==================================================
  Coverage              97.16%   97.16%           
  Complexity              4116     4116           
==================================================
  Files                    371      371           
  Lines                  10365    10365           
  Branches                 704      704           
==================================================
  Hits                   10071    10071           
  Misses                   287      287           
  Partials                   7        7           
Flag Coverage Δ
sql-engine 97.16% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ch/sql/opensearch/client/OpenSearchNodeClient.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -2,6 +2,6 @@
# SPDX-License-Identifier: Apache-2.0
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.4.2-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-bin.zip

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to bump gradle to 8.1.1 to match core?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A line from gradle output

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

I afraid something may not working. Just restarted build with --warning-mode all:

> Configure project :
The Report.enabled property has been deprecated. This is scheduled to be removed in Gradle 8.0. Please use the required property instead. See https://docs.gradle.org/7.6.1/dsl/org.gradle.api.reporting.Report.html#org.gradle.api.reporting.Report:enabled for more details.
        at build_2th86uuomtcgdejvuk5nrmh56$_run_closure7$_closure20.doCall(C:\GitHub\opensearch-project-sql-pr\build.gradle:132)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)

> Configure project :opensearch-sql-plugin
The AbstractArchiveTask.archiveName property has been deprecated. This is scheduled to be removed in Gradle 8.0. Please use the archiveFileName property instead. See https://docs.gradle.org/7.6.1/dsl/org.gradle.api.tasks.bundling.AbstractArchiveTask.html#org.gradle.api.tasks.bundling.AbstractArchiveTask:archiveName for more details.
        at build_z79fajveig7tp1hdihyed28n$_run_closure14$_closure30$_closure33.doCall(C:\GitHub\opensearch-project-sql-pr\plugin\build.gradle:227)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)
The AbstractArchiveTask.version property has been deprecated. This is scheduled to be removed in Gradle 8.0. Please use the archiveVersion property instead. See https://docs.gradle.org/7.6.1/dsl/org.gradle.api.tasks.bundling.AbstractArchiveTask.html#org.gradle.api.tasks.bundling.AbstractArchiveTask:version for more details.
        at build_z79fajveig7tp1hdihyed28n$_run_closure14$_closure30$_closure33.doCall(C:\GitHub\opensearch-project-sql-pr\plugin\build.gradle:228)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)
....
> Task :sql:generateGrammarSource
...
Gradle detected a problem with the following location: 'C:\GitHub\opensearch-project-sql-pr\sql\build\generated-src\antlr\main\org\opensearch\sql\sql\antlr\parser'. Reason: Task ':sql:generateEffectiveLombokConfig' uses this output of task ':sql:generateGrammarSource' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. This behaviour has been deprecated and is scheduled to be removed in Gradle 8.0. Execution optimizations are disabled to ensure correctness. See https://docs.gradle.org/7.6.1/userguide/validation_problems.html#implicit_dependency for more details.
....
> Task :ppl:generateGrammarSource
...
Gradle detected a problem with the following location: 'C:\GitHub\opensearch-project-sql-pr\ppl\build\generated-src\antlr\main\org\opensearch\sql\ppl\antlr\parser'. Reason: Task ':ppl:generateEffectiveLombokConfig' uses this output of task ':ppl:generateGrammarSource' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. This behaviour has been deprecated and is scheduled to be removed in Gradle 8.0. Execution optimizations are disabled to ensure correctness. See https://docs.gradle.org/7.6.1/userguide/validation_problems.html#implicit_dependency for more details.
....
> Task :legacy:generateGrammarSource
...
Gradle detected a problem with the following location: 'C:\GitHub\opensearch-project-sql-pr\legacy\build\generated-src\antlr\main\org\opensearch\sql\legacy\antlr\parser'. Reason: Task ':legacy:generateEffectiveLombokConfig' uses this output of task ':legacy:generateGrammarSource' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. This behaviour has been deprecated and is scheduled to be removed in Gradle 8.0. Execution optimizations are disabled to ensure correctness. See https://docs.gradle.org/7.6.1/userguide/validation_problems.html#implicit_dependency for more details.

Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants