Skip to content

Commit

Permalink
Remove Netty patching
Browse files Browse the repository at this point in the history
Not sure if this is necessary if we just use the plugin to compile module-info.java
  • Loading branch information
jduo committed Nov 28, 2023
1 parent 51968a6 commit 39408bd
Showing 1 changed file with 0 additions and 21 deletions.
21 changes: 0 additions & 21 deletions java/memory/memory-netty/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -58,27 +58,6 @@
</dependencies>

<profiles>
<profile>
<id>patch-netty-modules</id>
<activation>
<jdk>[9,]</jdk>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<!-- For this step only, use JDK 9 to patch Netty's module-info -->
<release>9</release>
<compilerArgs combine.children="append">
<arg>--patch-module=io.netty.buffer=${project.basedir}/../memory-netty-buffer-patch/target/arrow-memory-netty-buffer-patch-${project.version}.jar</arg>
</compilerArgs>
</configuration>
</plugin>
</plugins>
</build>
</profile>
<profile>
<!-- This profile turns on integration testing. It activates the failsafe plugin and will run any tests
with the 'IT' prefix. This should be run in a separate CI build or on developers machines as it potentially
Expand Down

0 comments on commit 39408bd

Please sign in to comment.