Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug of specificity calculation #359

Merged
merged 2 commits into from
Aug 22, 2024
Merged

fixed bug of specificity calculation #359

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ba4b71
fixed bug of specificity calculation
ellabarkan Jul 1, 2024
69aa7ec
Merge branch 'master' into fix_specificity_bug
ellabarkan Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fuse/eval/metrics/libs/classification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ def confusion_metrics(
if metric in ["sensitivity", "recall", "tpr"]:
res[metric] = tp / (tp + fn)
elif metric in ["specificity", "selectivity", "tnr"]:
res[metric] = tp / (tn + fp)
res[metric] = tn / (tn + fp)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh 😱 nice catch!

elif metric in ["precision", "ppv"]:
if tp + fp != 0:
res[metric] = tp / (tp + fp)
Expand Down
Loading