Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make op_id a really optional argument in OpCast #337

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

SagiPolaczek
Copy link
Collaborator

Minor change for a small thing that had annoyed me for a while :)

Note, this doesn't affect the pipelines (static & dynamic), rather working with ops as a mere objects.
For example:

from fuse.data import OpToTensor

# Assuming sample_dict is an 'NDict' with a key 'key' 

op = OpToTensor()
op(sample_dict, key="key", op_id=None)   # Must set op_id to some value although it's an optional 
op(sample_dict, key="key")   # After merging this PR :)

Mostly relevant for unit-testing.

Copy link
Collaborator

@mosheraboh mosheraboh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SagiPolaczek SagiPolaczek merged commit 8f3f538 into master Nov 27, 2023
4 checks passed
@SagiPolaczek SagiPolaczek deleted the sagi/dev branch November 27, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants