Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync v1.2.0 for zh-cn #73

Merged
merged 3 commits into from
Jul 14, 2023
Merged

sync v1.2.0 for zh-cn #73

merged 3 commits into from
Jul 14, 2023

Conversation

ShixiangWang
Copy link
Contributor

@ShixiangWang ShixiangWang commented Jul 13, 2023 •
edited
Loading

I am updating the Chinese version of coc to v1.2.0 by line-by-line check.

@ShixiangWang
Copy link
Contributor Author

@XueyiDong If you have time, please help me double-check this.

XueyiDong
XueyiDong approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@XueyiDong XueyiDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Shixiang! Your translation looks good to me.

@ShixiangWang
Copy link
Contributor Author

@XueyiDong Thank you :)

@ShixiangWang
Copy link
Contributor Author

@kevinrue Hi Kev, are you in charge of this repo? Could you merge this?

@XueyiDong
Copy link
Contributor

XueyiDong commented Jul 14, 2023 •
edited
Loading

Hi @ShixiangWang,
Forgot to mention, can you please also update the version number in index.Rmd and add your name in about.Rmd? Thanks!

@ShixiangWang
Copy link
Contributor Author

Of course.

@kevinrue
Copy link
Collaborator

@kevinrue Hi Kev, are you in charge of this repo? Could you merge this?

Yes I can do. I was waiting some sort of confirmation that it's ready to merge.

Thanks!

@kevinrue kevinrue merged commit 7451b3b into Bioconductor:main Jul 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XueyiDong XueyiDong XueyiDong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShixiangWang @XueyiDong @kevinrue