Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.2.0 new features and fixes #64

Merged
merged 14 commits into from
Sep 25, 2023
Merged

v0.2.0 new features and fixes #64

merged 14 commits into from
Sep 25, 2023

Conversation

BioTurboNick
Copy link
Owner

@BioTurboNick BioTurboNick commented Sep 19, 2023

This PR introduces several changes; "big" enough I'll call it v0.2 in case anyone doesn't like the look:

(edited to reflect current state)

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023

Codecov Report

Merging #64 (403274c) into master (9335d91) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master     #64      +/-   ##
=========================================
- Coverage    0.18%   0.16%   -0.03%     
=========================================
  Files           9       9              
  Lines         550     620      +70     
=========================================
  Hits            1       1              
- Misses        549     619      +70     
Files Changed Coverage Δ
src/AbbreviatedStackTraces.jl 0.66% <0.00%> (-0.29%) ⬇️
src/override-errorshow.jl 0.00% <0.00%> (ø)
src/override-stacktraces.jl 0.00% <0.00%> (ø)
src/override-vscode.jl 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BioTurboNick
Copy link
Owner Author

BioTurboNick commented Sep 22, 2023

Also going to try out simplifying the omitted parts of the trace. We don't really need the range of the omitted frames, as the range will be obvious from the included frames. Also moving it to one line, and in 1.10+ making it italic, makes the internal line less distracting so you can focus on the included lines.

Also makes it less silly if only one frame is removed.

image image

@BioTurboNick BioTurboNick changed the title Test of relying on new public api definitions in Julia Test of relying on new public api definitions in Julia; simplified internal frame display Sep 22, 2023
@BioTurboNick BioTurboNick changed the title Test of relying on new public api definitions in Julia; simplified internal frame display v0.2.0 new features and fixes Sep 25, 2023
@BioTurboNick BioTurboNick merged commit b487ff0 into master Sep 25, 2023
24 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove VSCode extension overrides setting err global once incorporated into it.
3 participants