Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull this #673

Merged
merged 12 commits into from
Apr 15, 2024
Merged

pull this #673

merged 12 commits into from
Apr 15, 2024

Conversation

nsjuty
Copy link
Contributor

@nsjuty nsjuty commented Apr 15, 2024

Internal reference

e.g. #596

Description

  • e.g. Modified Gene profile

Motivation and context

e.g. new field standards in gene nomenclature led to...

Have these been tested?

  • e.g. New draft tested against JSON document...

What should reviewers focus on?

e.g. The new nomenclature of...

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change which adds new content)
  • Modified content (non-breaking change which modifies existing content)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Future TO-DOs

  • e.g. Once reviewed, check webpage update...

nsjuty and others added 12 commits February 14, 2024 11:52
gbh biosample work
Deleted $validation section since that's only used to add constraints to profiles
* Fix typos in anatomicalSystem
* Fix casing with Submitter --> submitter
* Change `grant` to `funding` for consistency with schema.org
* Change parent class from Bioschemas:BioSample to Bioschemas:Sample after confirmation with Nick
@nsjuty nsjuty merged commit 1cecc6a into BioSchemas:master Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants