Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add files via upload #646

Merged
merged 4 commits into from
Apr 6, 2023
Merged

Add files via upload #646

merged 4 commits into from
Apr 6, 2023

Conversation

nsjuty
Copy link
Contributor

@nsjuty nsjuty commented Apr 6, 2023 •
edited
Loading

  • added sameAs
  • removed irrelevant text from description field

Internal reference

e.g. #596

Description

  • e.g. Modified Gene profile

Motivation and context

e.g. new field standards in gene nomenclature led to...

Have these been tested?

  • e.g. New draft tested against JSON document...

What should reviewers focus on?

e.g. The new nomenclature of...

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change which adds new content)
  • Modified content (non-breaking change which modifies existing content)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Future TO-DOs

  • e.g. Once reviewed, check webpage update...

nsjuty and others added 4 commits April 6, 2023 16:45
@nsjuty
Add files via upload
ddfcf7a 
- added sameAs
- removed irrelevant text from description field
@gtsueng
Update and rename Sample_v0.3-DRAFT.jsonld to Sample_v0.3-DRAFT.json
470edeb 
Fix parent class, formatting of summary of changes, add validation rules
@gtsueng
Update Sample_v0.3-DRAFT.json
e75a583 
fix typo
@gtsueng
Update Sample_v0.3-DRAFT.json
bec3a22
gtsueng
gtsueng approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@gtsueng gtsueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in DDE on its own

@gtsueng gtsueng merged commit bfa3f1e into master Apr 6, 2023
@gtsueng gtsueng deleted the nsjuty-patch-3 branch April 6, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtsueng gtsueng gtsueng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsjuty @gtsueng