Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cluster() wrapper #100

Merged
merged 1 commit into from
Apr 12, 2022
Merged

add cluster() wrapper #100

merged 1 commit into from
Apr 12, 2022

Conversation

pdimens
Copy link
Collaborator

@pdimens pdimens commented Apr 12, 2022

A clear and descriptive title (No issue numbers please)

This template is extensive, so fill out all that you can. If are a new contributor or unsure about any section, leave it empty and a reviewer will help you 😄. If anything in this template isn't relevant, just delete or ignore it._

Types of changes

This PR implements the following changes:
(tick any that apply)

  • ✨ New feature (A non-breaking change which adds functionality).
  • 🐛 Bug fix (A non-breaking change, which fixes an issue).
  • 💥 Breaking change (fix or feature that would cause existing functionality to change).

📋 Additional details

replace this block of text with your information

  • If you have implemented new features or behaviour

    • Provide a description of the addition in as many details as possible.

    • Provide justification of the addition.

    • Provide a runnable example of use of your addition. This lets reviewers
      and others try out the feature before it is merged or makes it's way to release.

  • If you have changed current behaviour...

    • Describe the behaviour prior to you changes

    • Describe the behaviour after your changes and justify why you have made the changes,
      Please describe any breakages you anticipate as a result of these changes.

    • Does your change alter APIs or existing exposed methods/types?
      If so, this may cause dependency issues and breakages, so the maintainer
      will need to consider this when versioning the next release.

    • If you are implementing changes that are intended to increase performance, you
      should provide the results of a simple performance benchmark exercise
      demonstrating the improvement. Especially if the changes make code less legible.

☑️ Checklist

it's ok if not all the boxes are checked 😄

  • 🎨 The changes implemented is consistent with the julia style guide.
  • 📘 I have updated and added relevant docstrings, in a manner consistent with the documentation styleguide.
  • 📘 I have added or updated relevant user and developer manuals/documentation in docs/src/.
  • 🆗 There are unit tests that cover the code changes I have made.
  • 🆗 The unit tests cover my code changes AND they pass.
  • 🆗 All changes should be compatible with the latest stable version of Julia.
  • 💭 I have commented liberally for any complex pieces of internal code.

@pdimens pdimens merged commit f40807e into dev Apr 12, 2022
@pdimens pdimens deleted the pca branch April 12, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant