Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for valid acquisitions #80

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Add test for valid acquisitions #80

merged 1 commit into from
Dec 16, 2024

Conversation

dstansby
Copy link
Collaborator

Fixes #38, depends on #79.

I haven't written a test yet because it's going to be a bit more complicated that usual to construct an invalid zarr group heirarchy.

@dstansby dstansby changed the title Add interface for getting wells in a HCS Add test for valid acquisitions Dec 11, 2024
Base automatically changed from get-wells to main December 14, 2024 09:10
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.12%. Comparing base (60c8421) to head (7a55dcd).

Files with missing lines Patch % Lines
src/ome_zarr_models/v04/hcs.py 75.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   92.47%   92.12%   -0.36%     
==========================================
  Files          23       23              
  Lines         771      787      +16     
==========================================
+ Hits          713      725      +12     
- Misses         58       62       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dstansby dstansby marked this pull request as ready for review December 14, 2024 09:11
@dstansby dstansby merged commit 7cf0fd9 into main Dec 16, 2024
3 of 5 checks passed
@dstansby dstansby deleted the check-acqusitions branch December 16, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.9. "well" metadata
1 participant