Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes unconditional pop with return in thumb #1449

Merged
merged 1 commit into from
Mar 23, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion plugins/thumb/thumb_mem.ml
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@ module Make(CT : Theory.Core) = struct
sp += const Int.(List.length regs * 4);
] in
let ctrl = CT.jmp (load s32 (var sp)) in
CT.branch ~?cnd (CT.blk null data ctrl) (seq [])
match cnd with
| `AL -> CT.blk null data ctrl
| _ -> CT.branch ~?cnd (CT.blk null data ctrl) (seq [])


let push regs cnd = branch cnd [
Expand Down