Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add localized string feature add open file function for cache folder #19

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

GreenSnakeLinux
Copy link
Contributor

add localized string feature
add open file function for cache folder

Copy link
Owner

@Bigfoot71 Bigfoot71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems to propose useful additions; thank you very much for this contribution!

A few adjustments are necessary, and overall, I think all these additions can be simplified into just two C functions: LoadCacheFile (for example) and GetL10NString directly in helper.c.

Please read the comments for more information. If you have any feedback on mine, feel free to share!

Thanks again for your contribution!

Edit: And don't forget to add the declarations of the new functions in raymob.h and to include the descriptions in the header rather than in the source files

app/src/main/cpp/deps/raymob/helper.c Show resolved Hide resolved
app/src/main/cpp/deps/raymob/features.c Show resolved Hide resolved
@GreenSnakeLinux
Copy link
Contributor Author

Awesome, all those adjustment are great and simpler

@Bigfoot71
Copy link
Owner

@GreenSnakeLinux I hope you're doing well. I wanted to check if you were planning to make the suggested changes from the review, so I can validate them and accept your contribution?

@GreenSnakeLinux
Copy link
Contributor Author

@Bigfoot71 did you received a notification about my update ?

@Bigfoot71
Copy link
Owner

@Bigfoot71 did you received a notification about my update ?

I just saw this, I'm quite busy, I'll merge this evening (at home), there will be a few adjustments to make.
Thanks again!

@Bigfoot71 Bigfoot71 merged commit 8ad6167 into Bigfoot71:master Oct 21, 2024
Bigfoot71 added a commit that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants