Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade this module to fit 3.0 #3

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Hardwell369
Copy link
Contributor

This pull request includes changes to the src/sql_join_2/__init__.py file to improve the handling of SQL inputs and remove unused constants. The most important changes include adding validation for SQL inputs, modifying how SQL strings are read and parsed, and updating the output format.

Improvements to SQL input handling:

  • Added validation to ensure sql1 and sql2 are not empty before proceeding with the function execution.
  • Modified the way SQL strings are read and checked if they are dictionaries to extract the SQL string properly.

Codebase simplification:

  • Removed the LEARNING_ALGORITHMS and FAI_CLUSTERS constants, which were no longer being used in the codebase.

Output format update:

  • Changed the output format from writing text to writing JSON, encapsulating the SQL string in a dictionary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant