Merge pull request #3 from Azure/master

Update 8/3

.azure-pipelines/BranchProtectionForPrivateRepo.yml

@@ -2,7 +2,7 @@ jobs:
   - job: "BranchProtectionForPrivateRepo"
     pool:
       vmImage: 'Ubuntu 16.04'
-    condition: and(variables['PRIVATE'], eq(variables['System.PullRequest.TargetBranch'], 'master'))
+    condition: and(variables['PRIVATE'], eq(variables['System.PullRequest.TargetBranch'], 'main'))
     steps:
     - script: '>&2 echo "the branch is protected"'
       failOnStderr: true

.azure-pipelines/ShouldSendPRToMain.yml

@@ -0,0 +1,8 @@
+jobs:
+  - job: "ShouldSendPRToMain"
+    pool:
+      vmImage: 'Ubuntu 16.04'
+    condition: eq(variables['System.PullRequest.TargetBranch'], 'master')
+    steps:
+    - script: '>&2 echo "##vso[task.logissue type=error]Please edit the pull request to targeting new default branch main"'
+      failOnStderr: true

.azure-pipelines/azure-pipelines-data-container.yml

@@ -3,7 +3,7 @@ schedules:
   displayName: Daily build
   branches:
     include:
-    - master
+    - main
   always: true
 
 pool:

.github/PULL_REQUEST_TEMPLATE.md

@@ -2,16 +2,16 @@
 </i>
 
 ### Changelog
-Please ensure to add changelog with this PR by answering the following questions.
-  1. What's the purpose of the update?    
-      - [ ] new service onboarding 
-      - [ ] new API version 
-      - [ ] update existing version for new feature 
+Add a changelog entry for this PR by answering the following questions:
+  1. What's the purpose of the update?
+      - [ ] new service onboarding
+      - [ ] new API version
+      - [ ] update existing version for new feature
       - [ ] update existing version to fix swagger quality issue in s360
-      - [ ] Other, please clarify 
-  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
-  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
-  4. If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.
+      - [ ] Other, please clarify
+  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
+  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
+  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
       - [ ] SDK of .NET (need service team to ensure code readiness)
       - [ ] SDK of Python
       - [ ] SDK of Java
@@ -20,7 +20,7 @@ Please ensure to add changelog with this PR by answering the following questions
       - [ ] PowerShell
       - [ ] CLI
       - [ ] Terraform
-      - [ ] No, no need to refresh for updates in this PR
+      - [ ] No refresh required for updates in this PR
 
 ### Contribution checklist:
 - [ ] I commit to follow the [Breaking Change Policy](http://aka.ms/bcforapi) of "no breaking changes"
@@ -29,24 +29,32 @@ Please ensure to add changelog with this PR by answering the following questions
 
 If any further question about AME onboarding or validation tools, please view the [FAQ](https://aka.ms/faqinprreview).
 
-### ARM API Review Checklist
-- [ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
+### ARM API Review Checklist 
+
+> **Applicability**: :warning: 
+>
+> If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.
+> - Change to data plane APIs 
+> - Adding new properties 
+> - All removals
+
+Otherwise your PR may be subject to ARM review requirements. Complete the following:
+- [ ] Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
+  - Adding a new service
   - Adding new API(s)
   - Adding a new API version
-  -  [ ] Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
-  - Adding a new service
+    -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit (including refactoring) and then push new changes, including version updates, in separate commits.
 
-- [ ] Please ensure you've reviewed following [guidelines](https://aka.ms/rpguidelines) including [ARM resource provider contract](https://github.com/Azure/azure-resource-manager-rpc) and [REST guidelines](https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md). Estimated time (4 hours). This is required before you can request review from ARM API Review board.
+- [ ] Ensure you've reviewed following [guidelines](https://aka.ms/rpguidelines) including [ARM resource provider contract](https://github.com/Azure/azure-resource-manager-rpc) and [REST guidelines](https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md). Estimated time (4 hours). This is required before you can request review from ARM API Review board.
 
 - [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (*RP Manifest Approvers* team under <ins>Azure Resource Manager service</ins>) from IcM and reach out to them. 
 
 ### Breaking Change Review Checklist 
-If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the [Breaking Change Policy](http://aka.ms/bcforapi). 
-
-- [ ] Removing API(s) in stable version
-- [ ] Removing properties in stable version
-- [ ] Removing API version(s) in stable version
-- [ ] Updating API in stable or public preview version with Breaking Change Validation errors
+If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the [Breaking Change Policy](http://aka.ms/bcforapi). 
+- [ ] Removing API(s) in a stable version
+- [ ] Removing properties in a stable version
+- [ ] Removing API version(s) in a stable version
+- [ ] Updating API in a stable or public preview version with Breaking Change Validation errors
 - [ ] Updating API(s) in public preview over 1 year (refer to [Retirement of Previews](https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/37683/Retirement-of-Previews))
 
 **Action**: to initiate an evaluation of the breaking change, create a new intake using the [template for breaking changes](https://aka.ms/Breakingchangetemplate). Addition details on the process and office hours are on the [Breaking change Wiki](https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/37684/Breaking-Changes).

.github/comment.yml

@@ -6,7 +6,7 @@
     booleanFilterExpression: "!(ARMSignedOff||ARMChangesRequested||Approved-OkToMerge||WaitForARMRevisit)"
     onCheckedLabels:
       - WaitForARMFeedback
-    onCheckedComments: "Hi, @${PRAuthor} your PR are labelled with <b> WaitForARMFeedback</b>. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @${PRAssignee} "
+    onCheckedComments: "Hi, @${PRAuthor} your PR are labelled with <b> WaitForARMFeedback</b>. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com)."
 
 - rule:
     type: label

.github/pull_request_assignment.yml

@@ -12,6 +12,12 @@
       - "specification/confidentialledger/data-plane/**"
     reviewers:
       - christothes 
+
+- rule:
+    paths:
+      - "specification/@(applicationinsights|operationalinsights)/**"
+    reviewers:
+      - akning-ms
 
 - rule:
     # eventgrid data-plane PR
@@ -47,14 +53,8 @@
     paths:
       - "specification/network/**"
     reviewers:
-      - kairu-ms
       - lirenhe
 
-- rule:
-    paths:
-      - "specification/@(applicationinsights|operationalinsights)/**"
-    reviewers:
-      - kairu-ms
 
 - rule:
     paths: "specification/@(resources|powerplatform|appplatform|deviceupdate)/**"
@@ -69,7 +69,7 @@
 - rule:
     paths: "specification/sql/**"
     reviewers:
-      - akning-ms
+      - zhenglaizhang
 
 - rule:
     paths: "specification/signalr/**"
@@ -92,42 +92,36 @@
     reviewers:
       - ArcturusZhang
 
-- rule:
-    paths:
-      - "specification/azureactivedirectory/**"
-    reviewers:
-      - njuCZ
-
 - rule:
     paths:
       - "specification/authorization/**"
     reviewers:
-      - qianwens
+      - ruowan
 
 - rule:
     paths:
       - "specification/datafactory/**"
     reviewers:
-      - qianwens
+      - leni-msft
 
 - rule:
     paths:
       - "specification/monitor/**"
     reviewers:
       - weidongxu-microsoft
-      - kairu-ms
 
 - rule:
     paths:
       - "specification/storage/**"
     reviewers:
-      - Juliehzl
+      - jianyexi
 
 
 - rule:	
     paths: "specification/mediaservices/**"	
     reviewers:	
       - allenjzhang
+
 - rule:
     paths:
       - "specification/containerregistry/**"
@@ -177,13 +171,6 @@
     reviewers:
       - zhenglaizhang
 
-- rule:
-    paths: 
-      - "specification/azurestack/**"
-      - "specification/automation/**"
-    reviewers:
-      - xiaoxuqi-ms
-
 - rule:
     paths:
       - "documentation/**"
@@ -210,18 +197,17 @@
     paths:
       - "**"
     reviewers:
-      - erich-wang
       - PhoenixHe-msft
       - lirenhe
       - weidongxu-microsoft
       - ArcturusZhang
       - raych1
-      - ChenTanyi
-      - njuCZ
       - akning-ms
       - leni-msft
-      - qianwens
       - ruowan
       - jianyexi
       - zhenglaizhang
       - chunyu3
+      - changlong-liu
+      - msyyc
+      - qwordy