Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use codecov #20

Merged
merged 3 commits into from
Mar 10, 2022
Merged

feat: use codecov #20

merged 3 commits into from
Mar 10, 2022

Conversation

samandmoore
Copy link
Member

📰 Summary of changes

What is the new functionality added in this PR?

Switch to codecov

Reviewers

/domain @Betterment/charlatan-maintainers
/no-platform

@nanda-prbot
Copy link

Needs somebody from @Betterment/charlatan-maintainers to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@samandmoore
Copy link
Member Author

/no-platform

(need this for policy bot since it can't read the PR description for this sign-off)

@nanda-prbot
Copy link

Needs somebody from @Betterment/charlatan-maintainers to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

Copy link
Contributor

@btrautmann btrautmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@fa8ffe7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage        ?   95.34%           
=======================================
  Files           ?        4           
  Lines           ?       86           
  Branches        ?        0           
=======================================
  Hits            ?       82           
  Misses          ?        4           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa8ffe7...2a8f1b8. Read the comment docs.

@btrautmann
Copy link
Contributor

btrautmann commented Mar 10, 2022

<< domainlgtm

to satisfy nanda 😉

nanda-prbot
nanda-prbot previously approved these changes Mar 10, 2022
Copy link

@nanda-prbot nanda-prbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 🌞 🌟 🍔

@nanda-prbot
Copy link

Needs @btrautmann to provide domain review

When you finish a round of review, be sure to say you've finished or sign off on the PR, e.g.:

TAFN or DomainLGTM

If you're too busy to review, unclaim the PR, e.g.:

@myname >> domain

HOW TO: Give Feedback

@nanda-prbot nanda-prbot dismissed their stale review March 10, 2022 17:03

Additional review is required

@nanda-prbot
Copy link

Needs @btrautmann to provide domain review

When you finish a round of review, be sure to say you've finished or sign off on the PR, e.g.:

TAFN or DomainLGTM

If you're too busy to review, unclaim the PR, e.g.:

@myname >> domain

HOW TO: Give Feedback

@btrautmann
Copy link
Contributor

Oops lol

domainlgtm

Copy link

@nanda-prbot nanda-prbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 💫 👯 🚢

Copy link
Contributor

@btrautmann btrautmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<< domainlgtm 🎉

@nanda-prbot
Copy link

Approved! 🥑 👏 🌮

@samandmoore samandmoore merged commit f419b26 into main Mar 10, 2022
@samandmoore samandmoore deleted the samandmoore-patch-1 branch March 10, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants