Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade deps #11

Merged
merged 1 commit into from
Feb 7, 2022
Merged

chore: Upgrade deps #11

merged 1 commit into from
Feb 7, 2022

Conversation

CelticMajora
Copy link
Contributor

📰 Summary of changes

  • Updates dart to 2.15.0
  • upgrades dio
  • upgrades test

Reviewers

/domain @Betterment/charlatan-maintainers
/no-platform

@nanda-prbot
Copy link

Needs somebody from @Betterment/charlatan-maintainers to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@github-actions
Copy link

github-actions bot commented Feb 4, 2022

LCOV of commit acc1c98 during CI #33

Summary coverage rate:
  lines......: 95.3% (82 of 86 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

Copy link
Member

@samandmoore samandmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samandmoore
Copy link
Member

we probably need to cut a release with this huh?

wanna pair up on that? I wanna make sure you can do that too since I'm going on leave soon hehe

@samandmoore
Copy link
Member

<<domainlgtm

Copy link

@nanda-prbot nanda-prbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 👍 🍕 🎆

@CelticMajora
Copy link
Contributor Author

we probably need to cut a release with this huh?

wanna pair up on that? I wanna make sure you can do that too since I'm going on leave soon hehe

Sure, probably should do that for better_test_reporter as well.

@CelticMajora CelticMajora merged commit 667a401 into main Feb 7, 2022
@CelticMajora CelticMajora deleted the update-2.15.0-and-various-deps branch February 7, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants