Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ReadMe Stub for Leiningen Jack-In with REBL #543

Merged
merged 2 commits into from
Jan 12, 2020
Merged

Fix ReadMe Stub for Leiningen Jack-In with REBL #543

merged 2 commits into from
Jan 12, 2020

Conversation

ozimos
Copy link
Contributor

@ozimos ozimos commented Jan 10, 2020 •
edited
Loading

REBL Instructions for Leiningen

What has Changed?

  • Add REBL Setup instructions for Leiningen

Fixes #542

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Made sure I am directing this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I am changed the default PR base branch, so that it is not master. (Sorry for the nagging.)
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
    • If I am fixing the issue, I have used GitHub's fixes/closes syntax
    • If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.
  • Created the issue I am fixing/addressing, if it was not present.
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.

The Calva Team PR Checklist:

Before merging we (at least one of us) have:

  • Made sure the PR is directed at the dev branch (unless reasons).
  • Read the source changes.
  • Given feedback and guidance on source changes, if needed. (Please consider noting extra nice stuff as well.)
  • Tested the VSIX built from the PR (well, if this is a PR that changes the source code.)
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
  • If need be, had a chat within the team about particular changes.

Ping @PEZ, @kstehn, @cfehse, @bpringe

bpringe
bpringe requested changes Jan 11, 2020
View reviewed changes
Copy link
Member

@bpringe bpringe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking time to add this!

docs/readthedocs/source/rebl.md Outdated Show resolved Hide resolved
@dependabot @ozimos
Bump npm from 6.13.1 to 6.13.4
9c23634 
Bumps [npm](https://github.com/npm/cli) from 6.13.1 to 6.13.4.
- [Release notes](https://github.com/npm/cli/releases)
- [Changelog](https://github.com/npm/cli/blob/latest/CHANGELOG.md)
- [Commits](npm/cli@v6.13.1...v6.13.4)

Signed-off-by: dependabot[bot] <support@github.com>
@ozimos
Update rebl.md
b54f5f9 
REBL Instructions for Leiningen
@ozimos ozimos requested a review from bpringe January 12, 2020 09:54
@PEZ
Copy link
Collaborator

PEZ commented Jan 12, 2020

This is great. Thanks for contributing!

@PEZ PEZ merged commit b1fbca4 into BetterThanTomorrow:dev Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpringe bpringe Awaiting requested review from bpringe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ozimos @PEZ @bpringe