-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROPOSAL enhance REPL window handling #422
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci]
Addressing #311 [skip ci]
Disable repl needning commands when not connected (To aid discovery)
…/BetterThanTomorrow/calva into wip/enhance-repl-window-handling
Clarify that they also clear the history. Move the REPL window command subs to the repl-window module
[skip ci]
Added <repl#msgid> to the output strings for async output.
…/BetterThanTomorrow/calva into wip/enhance-repl-window-handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has Changed?
src/connector.ts
NReplEvaluation
innrepl/index.ts
eval()
andloadfile()
innrepl/index.ts
NReplEvaluation
class to ensure both methods behave identical.repl-window.ts
improved reconnect sequenceNReplEvaluation
class to retrieve error output and display it in the REPL window. Unfortunately with will not show errors on the first connect with shadow-cljs because the repl needs some time to initialize completely and show the error during eval. I the REPL window is closed and reopened the error is shown on reconnect. This is maybe better than nothing. ggread-line
from the REPL window ( see clojure.core/read-line doesn't work in Calva REPL #377) and in the editor."Interrupt running Evaluations"
(ctrl+alt+c ctrl+alt+d
) to interrupt all running evaluations in editors and REPL windows.My Calva PR Checklist
I have:
dev
branch. (Or have specific reasons to target some other branch.)master
. (Sorry for the nagging.)ci/circleci: build
test. (For now you'll need to opt in to the CircleCI New Experience UI to see the Artifacts tab, because bug.)Before merging we (at least one of us) have:
dev
branch (unless reasons).Ping @PEZ, @kstehn, @cfehse