Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2266 ns form meta #2267

Merged
merged 2 commits into from
Jul 30, 2023
Merged

2266 ns form meta #2267

merged 2 commits into from
Jul 30, 2023

Conversation

PEZ
Copy link
Collaborator

@PEZ PEZ commented Jul 30, 2023

What has changed?

We used to bail out if the form in front of ns or in-ns was not of type id, making us return null if the namespace symbol had metadata. Now we examine all sexps in ns and in-ns forms to try find the namespace symbol.

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Made sure there is an issue registered with a clear problem statement that this PR addresses, (created the issue if it was not present).
    • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
    • Referenced the issue I am fixing/addressing in a commit message for the pull request.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • [ ] Added to or updated docs in this branch, if appropriate
  • Tests
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
  • Formatted all JavaScript and TypeScript code that was changed. (use the prettier extension or run npm run prettier-format)
  • Confirmed that there are no linter warnings or errors (use the eslint extension, run npm run eslint before creating your PR, or run npm run eslint-watch to eslint as you go).

Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik

@PEZ PEZ requested a review from bpringe July 30, 2023 15:07
@netlify
Copy link

netlify bot commented Jul 30, 2023

Deploy Preview for calva-docs ready!

Name Link
🔨 Latest commit d93f5d8
🔍 Latest deploy log https://app.netlify.com/sites/calva-docs/deploys/64c67cc0b673c60008076151
😎 Deploy Preview https://deploy-preview-2267--calva-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PEZ PEZ merged commit 21c784c into dev Jul 30, 2023
@PEZ PEZ deleted the 2266-ns-form-meta branch July 30, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants