Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to auto-refer repl-utilities #2155

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Add option to auto-refer repl-utilities #2155

merged 1 commit into from
Apr 12, 2023

Conversation

PEZ
Copy link
Collaborator

@PEZ PEZ commented Apr 12, 2023

I've added an option to have REPL utilities (clojure.main/repl-requires) auto-referred on connect of the REPL. So that things like (doc <something>) works. This works when starting a clj REPL on the command line, Leiningen does it, and so does CIDER.

I made it enabled by default to happen on-connect, and there are options such that the user can opt out entirely, and also to opt in for it happening in all namespaces.

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • [ ] Added to or updated docs in this branch, if appropriate
  • Tests
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
  • Created the issue I am fixing/addressing, if it was not present.
  • Formatted all JavaScript and TypeScript code that was changed. (use the prettier extension or run npm run prettier-format)
  • Confirmed that there are no linter warnings or errors (use the eslint extension, run npm run eslint before creating your PR, or run npm run eslint-watch to eslint as you go).

Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik

@PEZ PEZ requested a review from bpringe April 12, 2023 21:36
@PEZ PEZ merged commit a1beb61 into dev Apr 12, 2023
@PEZ PEZ deleted the 2154-repl-requires branch April 12, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant