Include cwd in jack-in command line

[PEZ]

What has changed?

When constructing the Jack-in command line we wrap it in pushd changing the working directory to the started project's root and then popd to restore. The command line gets to be: (pushd <project-root> <;|&> <jack-in-command-line> <;|&> popd. The commands are separated by & on Windows/cmd.exe and by ; on Mac/Linux.

• Fix Include a change directory command with the jack-in command line #2147

My Calva PR Checklist

I have:

• Read How to Contribute.
• Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
• Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
• Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
• Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
• Added to or updated docs in this branch, if appropriate
• Tests
  • Tested the particular change
  • Figured if the change might have some side effects and tested those as well.
• Referenced the issue I am fixing/addressing in a commit message for the pull request.
  • If I am fixing the issue, I have used GitHub's fixes/closes syntax
• Created the issue I am fixing/addressing, if it was not present.
• Formatted all JavaScript and TypeScript code that was changed. (use the prettier extension or run npm run prettier-format)
• Confirmed that there are no linter warnings or errors (use the eslint extension, run npm run eslint before creating your PR, or run npm run eslint-watch to eslint as you go).

Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik

[bpringe]

What's the point of wrapping the command in parens?

[PEZ]

What's the point of wrapping the command in parens?

It's what creates the sub shell. So if you copy the command and run it, then exit from it, you will be back in the same current directory as from where you started it.

[PEZ]

That said. I now tested it on Windows, and it doesn't create a sub shell there, so not as universal as I had hoped. Now using pushd/popd instead to achieve the same effect. To my surprise those commands exist in cmd.exe.