Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Notebooks file association to a separate extension #2119

Merged
merged 5 commits into from
Mar 18, 2023

Conversation

PEZ
Copy link
Collaborator

@PEZ PEZ commented Mar 17, 2023

Because of Calva Clojure Notebooks interfering with LiveShare sessions:

I have moved the Notebook file association part of the Calva extension manifest over to a separate extension, Calva Spritz. It only provides these associations, and nothing else. All Notebook supporting code remains in Calva. Calva Spritz is downloaded and enabled together with Calva. Once the LiveShare team fixes that bug, we can move the file associations back to Calva.

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Added to or updated docs in this branch, if appropriate
  • Tests
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
  • Formatted all JavaScript and TypeScript code that was changed. (use the prettier extension or run npm run prettier-format)
  • Confirmed that there are no linter warnings or errors (use the eslint extension, run npm run eslint before creating your PR, or run npm run eslint-watch to eslint as you go).

Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik

@PEZ PEZ requested review from Cyrik and bpringe March 17, 2023 23:04
Copy link
Member

@Cyrik Cyrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a great idea!

docs/site/live-share.md Outdated Show resolved Hide resolved
notebooks-spritz/README.md Outdated Show resolved Hide resolved
PEZ and others added 3 commits March 18, 2023 09:03
Co-authored-by: Brandon Ringe <12722744+bpringe@users.noreply.github.com>
@PEZ PEZ merged commit 54059d3 into dev Mar 18, 2023
@PEZ PEZ deleted the 1850-spritz-liveshare-notebooks-workaround branch March 18, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants