Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repl UI updates #2107

Merged
merged 10 commits into from
Mar 14, 2023
Merged

Repl UI updates #2107

merged 10 commits into from
Mar 14, 2023

Conversation

PEZ
Copy link
Collaborator

@PEZ PEZ commented Mar 14, 2023

What has changed?

The changelog pretty much sums it up:

I've also

  • removed some strange needREPLUi state updates, that I don't think was ever used anywhere.
  • fixed some glitches with the repl type status and the status bar item for it.

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Added to or updated docs in this branch, if appropriate
  • Tests
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
    • If I am fixing the issue, I have used GitHub's fixes/closes syntax
    • If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.
  • Created the issue I am fixing/addressing, if it was not present.
  • Formatted all JavaScript and TypeScript code that was changed. (use the prettier extension or run npm run prettier-format)
  • Confirmed that there are no linter warnings or errors (use the eslint extension, run npm run eslint before creating your PR, or run npm run eslint-watch to eslint as you go).

Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik

@PEZ PEZ requested review from Cyrik and bpringe March 14, 2023 10:46
@PEZ PEZ merged commit 7d1146a into dev Mar 14, 2023
@PEZ PEZ deleted the 2103-repl-ui branch March 14, 2023 20:13
@PEZ
Copy link
Collaborator Author

PEZ commented Mar 14, 2023

Please don't hesitate to comment on the changes even though they are merged. 😄

bpringe
bpringe reviewed Mar 15, 2023
View reviewed changes
docs/site/evaluation.md
@@ -11,6 +11,10 @@ Calva tries to make it easy to evaluate code, supporting interactive development

NB: _The below assumes you have read about [Finding Calva Commands and Shortcuts](finding-commands.md)._

## Interrupting/stopping running evaluations

Sometimes you evaluate things that take a very long time to complete, or might not even ever complete (infinit loops, lazy sequences, things like that). Calva has a command for interrupting running evaluations. You find it in the VS Code command palette, as well as in the REPL status bar item menu, when the REPL is connected.
Copy link
Member

@bpringe bpringe Mar 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the "infinit" typo on dev. 🙂

bpringe
bpringe reviewed Mar 15, 2023
View reviewed changes
Copy link
Member

@bpringe bpringe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpringe bpringe bpringe left review comments

@Cyrik Cyrik Awaiting requested review from Cyrik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PEZ @bpringe