Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for debug response before returning eval operation #2082

Merged
merged 3 commits into from
Feb 15, 2023

Conversation

bpringe
Copy link
Member

@bpringe bpringe commented Feb 15, 2023

What has changed?

  • We now check for the debug response being defined before returning a new op

Fixes #2081

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Added to or updated docs in this branch, if appropriate
  • Tests
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
    • If I am fixing the issue, I have used GitHub's fixes/closes syntax
    • If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.
  • Created the issue I am fixing/addressing, if it was not present.
  • Formatted all JavaScript and TypeScript code that was changed. (use the prettier extension or run npm run prettier-format)
  • Confirmed that there are no linter warnings or errors (use the eslint extension, run npm run eslint before creating your PR, or run npm run eslint-watch to eslint as you go).

Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik

@bpringe bpringe marked this pull request as ready for review February 15, 2023 20:44
@PEZ
Copy link
Collaborator

PEZ commented Feb 15, 2023

Looks fantastic. This has been hitting me quite a bit lately.

@bpringe bpringe changed the title Check for debug response before return debug eval operation Check for debug response before returning eval operation Feb 15, 2023
@bpringe bpringe merged commit 6ddfee0 into dev Feb 15, 2023
@bpringe bpringe deleted the fix_eval_during_debug_bug branch February 15, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants