Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort deps.edn aliases #2036

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Conversation

ferdinand-beyer
Copy link
Contributor

@ferdinand-beyer ferdinand-beyer commented Jan 26, 2023

What has changed?

  • Sort the projectAliases array

Fixes #2035

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Added to or updated docs in this branch, if appropriate
  • Tests
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
    • Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
    • If I am fixing the issue, I have used GitHub's fixes/closes syntax
    • If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.
  • Created the issue I am fixing/addressing, if it was not present.
  • Formatted all JavaScript and TypeScript code that was changed. (use the prettier extension or run npm run prettier-format)
  • Confirmed that there are no linter warnings or errors (use the eslint extension, run npm run eslint before creating your PR, or run npm run eslint-watch to eslint as you go).

Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik

Copy link
Collaborator

@PEZ PEZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How neat and clean! 😄 Thanks! 🙏

@PEZ PEZ merged commit c2dbaff into BetterThanTomorrow:dev Jan 26, 2023
@PEZ
Copy link
Collaborator

PEZ commented Jan 26, 2023

I updated the PR description, deleting the documentation checklist section. We should probably make this clearer in the template. (It gets important because of previews in Slack only show the first part of the PR 😄 )

@ferdinand-beyer ferdinand-beyer deleted the sort-aliases branch January 26, 2023 10:13
@ferdinand-beyer
Copy link
Contributor Author

Thanks! Sorry about the checklist, there's a lot in it and I might have scanned over a few bits!

Looking forward to seeing my aliases sorted! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants