Fix evaluate updating UI, when there is no editor active #2027
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed?
When we evaluate connect sequence
afterCLJReplJackInCode
provided code, we useevaluate.evaluateCodeUpdatingUI
function. I don't know exactly why, but maybe it is because withUI
we mean both the REPL window and the decorations in the active editor. But if there is no active editor, we run into trouble. Most commands and shortcuts for evaluating things in the active editor havewhen
clauses that guards, but the jack-in should work regardless of active editor or not.This code is very messy and in bad need of restructuring. With this PR I pile on to the technical debt, because I don't have a good idea about how the code should be structure. It's a tiny change, just checking that we have an
editor
before we go access it. All use cases that have this will continue to work as before, and use cases that don't, might start working, and if they don't, they didn't work before either.In any case the issue exposing this problem is fixed by this.
My Calva PR Checklist
I have:
dev
branch. (Or have specific reasons to target some other branch.)published
. (Sorry for the nagging.)[Unreleased]
entry inCHANGELOG.md
, linking the issue(s) that the PR is addressing.[ ] Added to or updated docs in this branch, if appropriateci/circleci: build
test.npm run prettier-format
)npm run eslint
before creating your PR, or runnpm run eslint-watch
to eslint as you go).Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik