Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1910 use atom image #1911

Merged
merged 10 commits into from
Oct 24, 2022
Merged

1910 use atom image #1911

merged 10 commits into from
Oct 24, 2022

Conversation

PEZ
Copy link
Collaborator

@PEZ PEZ commented Oct 24, 2022

What has changed?

The "prescribed" way of running Atom package tests started to fail to often, so now we use the atom-docker-ci Docker image instead and run the tests using that. Much more reliable and since Atom is not developed anymore it should stay stable this way.

Fixes #1910

I also moved the test-grammar job earlier in the ci pipeline so that we don't have to wait for the build step to finish before getting feedback on grammar tests.

image

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • [ ] Added to or updated docs in this branch, if appropriate
  • Tests
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
    • [ ] Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
  • Created the issue I am fixing/addressing, if it was not present.
  • Formatted all JavaScript and TypeScript code that was changed. (use the prettier extension or run npm run prettier-format)
  • Confirmed that there are no linter warnings or errors (use the eslint extension, run npm run eslint before creating your PR, or run npm run eslint-watch to eslint as you go).

Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik

@PEZ PEZ requested a review from bpringe October 24, 2022 09:45
@PEZ PEZ merged commit 17a6c04 into dev Oct 24, 2022
@PEZ PEZ deleted the 1910-use-atom-image branch October 24, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant