Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init resultdoc once #1552

Merged
merged 1 commit into from
Feb 20, 2022
Merged

Init resultdoc once #1552

merged 1 commit into from
Feb 20, 2022

Conversation

PEZ
Copy link
Collaborator

@PEZ PEZ commented Feb 20, 2022

What has Changed?

We were creating subscriptions, lenses, and other resources for the output window on every connect. The most visible effect of this was that we crated a new Show stacktrace button every time.

This change returns the result doc early if it has already been initialized.

Fixes #1542

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • [ ] Added to or updated docs in this branch, if appropriate
  • Tests
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
    • Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
  • Formatted all JavaScript and TypeScript code that was changed. (use the prettier extension or run npm run prettier-format)
  • Confirmed that there are no linter warnings or errors (use the eslint extension or run npm run eslint).

Ping @PEZ, @bpringe

@PEZ PEZ merged commit 22f5516 into dev Feb 20, 2022
@PEZ PEZ deleted the 1542-init-resultdoc-once branch February 20, 2022 21:37
@PEZ PEZ linked an issue Feb 21, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print stacktrace link in REPL gets duplicated
1 participant