-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nrepl message log #1292
Add nrepl message log #1292
Conversation
Close #1198
Close #1198
06ee696
to
b3ef801
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome to finally see this happening! Haven't tried it yet, hopefully I get to do that during the day.
…/calva into add_nrepl_message_log
Change direction strings for nrepl logs
I think the code is ready now, I just need to add info to the docs about it. @PEZ Where should this go in the docs? We have multiple places for troubleshooting info about specific subjects on those particular pages. I'm not sure if this warrants a new, general troubleshooting page, or if we should fit it into some existing page. |
For now we can slap it in here https://calva.io/connect/#troubleshooting maybe? Hmm, that is not a perfect fit at all. Maybe instead create a page |
That sounds good to me! I'll be busy this weekend, but will get to it soon. |
What has Changed?
Closes #1198
My Calva PR Checklist
I have:
dev
branch. (Or have specific reasons to target some other branch.)published
. (Sorry for the nagging.)[Unreleased]
entry inCHANGELOG.md
, linking the issue(s) that the PR is addressing.ci/circleci: build
test. NB: You need to sign in/up at Circle CI to find the Artifacts tab.The Calva Team PR Checklist:
Before merging we (at least one of us) have:
dev
branch (unless reasons).Ping @PEZ, @bpringe