Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClojureScript Quick Start REPLs #1186

Merged
merged 5 commits into from
May 26, 2021
Merged

Add ClojureScript Quick Start REPLs #1186

merged 5 commits into from
May 26, 2021

Conversation

PEZ
Copy link
Collaborator

@PEZ PEZ commented May 25, 2021

What has Changed?

Similar to the Getting Started REPL. Add two commands for starting up standalone ClojureScript REPLs for browser or for node.

To assist in this I have also changed how the drams are configured. There is now a dram.edn file for each dram in the Dram repository. This file specifies which files should be downloaded and wether they should be opened or not. Like so for the ClojureScript Browser REPL dram:

{:name "ClojureScript Quick Start"
 :files [{:path "src/hello_world/core.cljs"
          :open? true}
         {:path "index.html"
          :open? true}
         {:path "deps.edn"
          :open? false}
         {:path ".gitignore"
          :open? false}]}

This creates the minimal ClojureScript app project and then the command jacks in to it. I haven't found a clean way to specify this jack-in in the dram file, so it is still configured via code, in Calva.

Fixes #1185

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Added to or updated docs in this branch, if appropriate
  • Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test. NB: You need to sign in/up at Circle CI to find the Artifacts tab.
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.

Ping @PEZ, @bpringe

@PEZ PEZ merged commit f7128dd into dev May 26, 2021
@PEZ PEZ deleted the fetch-dram-config-from-repo branch May 26, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant