Use deps.clj to launch deps.edn projects on Windows

[PEZ]

What has Changed?

bb.exe is bundled and on Windows used to launch deps.edn projects

Project type Clojure CLI is renamed to deps.edn

Change deps.edn launch on windows to use bb.exe

Refactored some of how the executable and the rest of the command line is built. Also refactored how the shell: param to childprocess is determined.

Since the project-types are set up statically, and we need to fetch the path to bb.exe dynamically, there is some non-config-driven parts introduced in jack-in.ts. I think that overall the refactoring made most things better, but then this eats away a bit of that... Anyway, I don't quite see how it could be avoided.

Fixes #1000

Might help with #997

TODO:

This needs to be tested

Mac

• deps.edn Mac
• lein Mac
• shadow-cljs Mac
• lein-shadow Mac
• generic Mac

Linux

• deps.edn Linux
• lein Linux
• shadow-cljs Linux
• lein-shadow Linux
• generic Linux

Windows

• deps.edn Windows
• lein Windows
• shadow-cljs Windows
• lein-shadow Windows
• generic Windows

My Calva PR Checklist

I have:

• Read How to Contribute.
• Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
• Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
• Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
• Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
• Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test. NB: There is a CircleCI bug that makes the Artifacts hard to find. Please see this issue for workarounds.
  • Tested the particular change
  • Figured if the change might have some side effects and tested those as well.
  • Smoke tested the extension as such.
• Referenced the issue I am fixing/addressing in a commit message for the pull request.
  • If I am fixing the issue, I have used GitHub's fixes/closes syntax
• Created the issue I am fixing/addressing, if it was not present.
• Added to or updated docs in this branch, if appropriate

The Calva Team PR Checklist:

Before merging we (at least one of us) have:

• Made sure the PR is directed at the dev branch (unless reasons).
• Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and tested it there if so.
• Read the source changes.
• Given feedback and guidance on source changes, if needed. (Please consider noting extra nice stuff as well.)
• Tested the VSIX built from the PR (well, if this is a PR that changes the source code.)
  • Tested the particular change
  • Figured if the change might have some side effects and tested those as well.
  • Smoke tested the extension as such.
• If need be, had a chat within the team about particular changes.

Ping @PEZ, @kstehn, @cfehse, @bpringe

[bpringe]

If by lein-shadow you mean a lein project with shadow-cljs config in the project.clj, which generates the shadow-cljs.edn, this worked for me on Linux.

[PEZ]

That's good. But lein-shadow means using the lein plugin with that name. 😍

[bpringe]

Ah yeah that was done with the project I tested. Also tested other project types in linux except generic (I'm still confused about that one a bit, and I know it may soon be removed?)