Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline evaluation result dissapears after a second #774

Closed
glebovmaksim opened this issue Aug 31, 2020 · 0 comments
Closed

Inline evaluation result dissapears after a second #774

glebovmaksim opened this issue Aug 31, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@glebovmaksim
Copy link

Peek 2020-08-31 20-00

The root of the problem is the decoration cleaning event. It fires not only when the content of the document changes, but also after saving the file. So, if my auto-save setting is on and I press alt+enter right after some typing, the following happens:

  1. The evaluation result appears.
  2. Auto save is performed.
  3. onDidChangeTextDocument event cleans the decoration.

The suggested fix is to clean the decoration only if the event contains real changes. PR is coming.

@bpringe bpringe added the bug Something isn't working label Aug 31, 2020
bpringe added a commit that referenced this issue Aug 31, 2020
Fix inline evaluation result dissapears after a second (#774)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants