Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconnecting a repl while connected fails #2301

Closed
PEZ opened this issue Aug 29, 2023 · 0 comments
Closed

Reconnecting a repl while connected fails #2301

PEZ opened this issue Aug 29, 2023 · 0 comments
Labels
bug Something isn't working connect regression Regression error repl

Comments

@PEZ
Copy link
Collaborator

PEZ commented Aug 29, 2023

When a repl is connected and I issue a command for connecting a repl the connection first is established, then I get disconnected. The expected behaviour is that Calva should properly disconnect the current repl and then connect the new one.

Manually first disconnecting the repl and then connecting a new (or the same) repl, works.
@PEZ PEZ added bug Something isn't working connect regression Regression error repl labels Aug 29, 2023
@PEZ PEZ mentioned this issue Sep 17, 2023
Merged
13 tasks
PEZ added a commit that referenced this issue Sep 18, 2023
@PEZ
Wrap nRepl client close in a promise
b408f86 
Poor (dumb) man's way to wait for `close` messages to have been sent
before destroying the socket.

* Fixes #2301
PEZ added a commit that referenced this issue Sep 19, 2023
@PEZ
Remove setConnectedState calls from close handler
cb80a72 
* The connected state is set to false from other places
* and this close comes late in the process, messing with the connect
* Fixes #2301
PEZ added a commit that referenced this issue Sep 19, 2023
@PEZ
Wrap nRepl client close in a promise
c6b2ec8 
Poor (dumb) man's way to wait for `close` messages to have been sent
before destroying the socket.

* Fixes #2301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working connect regression Regression error repl
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PEZ