-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort pre-selected project at the top in REPL connect menu #2043
Comments
julienvincent
added a commit
to julienvincent/calva
that referenced
this issue
Jan 30, 2023
The clojure-lsp refactor project in BetterThanTomorrow#2020 reworked the way the project picker menus work, adding additional information on a second line indicating which files contributed to a folder being picked as a valid clojure project. This turned out significant hurt the UX experience in workspaces with many clojure projects. This commit removes the additional information from the picker menus, shrinking the list items to a single line. Some other smaller changes included: - Projects are now grouped by their workspace root which should help make it easier to sort through the list visually. - Project folders are now sorted within their groups to make the list more deterministic. - Project folders show the path relative to the workspace root instead of the absolute path. This should help make scanning the list easier by removing unnecessary/duplicate information. Addresses BetterThanTomorrow#2041 Closes BetterThanTomorrow#2043
julienvincent
added a commit
to julienvincent/calva
that referenced
this issue
Jan 30, 2023
The clojure-lsp refactor project in BetterThanTomorrow#2020 reworked the way the project picker menus work, adding additional information on a second line indicating which files contributed to a folder being picked as a valid clojure project. This turned out significant hurt the UX experience in workspaces with many clojure projects. This commit removes the additional information from the picker menus, shrinking the list items to a single line. Some other smaller changes included: - Projects are now grouped by their workspace root which should help make it easier to sort through the list visually. - Project folders are now sorted within their groups to make the list more deterministic. - Project folders show the path relative to the workspace root instead of the absolute path. This should help make scanning the list easier by removing unnecessary/duplicate information. Addresses BetterThanTomorrow#2041 Closes BetterThanTomorrow#2043
julienvincent
added a commit
to julienvincent/calva
that referenced
this issue
Jan 30, 2023
The clojure-lsp refactor project in BetterThanTomorrow#2020 reworked the way the project picker menus work, adding additional information on a second line indicating which files contributed to a folder being picked as a valid clojure project. This turned out significant hurt the UX experience in workspaces with many clojure projects. This commit removes the additional information from the picker menus, shrinking the list items to a single line. Some other smaller changes included: - Projects are now grouped by their workspace root which should help make it easier to sort through the list visually. - Project folders are now sorted within their groups to make the list more deterministic. - Project folders show the path relative to the workspace root instead of the absolute path. This should help make scanning the list easier by removing unnecessary/duplicate information. Addresses BetterThanTomorrow#2041 Closes BetterThanTomorrow#2043
julienvincent
added a commit
to julienvincent/calva
that referenced
this issue
Jan 30, 2023
The clojure-lsp refactor project in BetterThanTomorrow#2020 reworked the way the project picker menus work, adding additional information on a second line indicating which files contributed to a folder being picked as a valid clojure project. This turned out significant hurt the UX experience in workspaces with many clojure projects. This commit removes the additional information from the picker menus, shrinking the list items to a single line. Some other smaller changes included: - Projects are now grouped by their workspace root which should help make it easier to sort through the list visually. - Project folders are now sorted within their groups to make the list more deterministic. - Project folders show the path relative to the workspace root instead of the absolute path. This should help make scanning the list easier by removing unnecessary/duplicate information. Addresses BetterThanTomorrow#2041 Closes BetterThanTomorrow#2043
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When there are several Clojure projects in a workspace, Calva presents a menu of them when Connect or Jack-in is requested. We also pre-select the closest project to the currently opened file.
This works good in many projects, but e.g. for Polylith, this pre-selection is not helpful, especially as the pre-selected item is often far from the Polylith project root.
A way, suggested by @seancorfield, to serve both types of structure better would be to sort the projects such that the pre-selected item is at the top. With the current sort that would mean that the project root is close to the pre-selected item.
The text was updated successfully, but these errors were encountered: