Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow show evaluation output somewhere else instead of the repl window #1767

Closed
pinkfrog9 opened this issue Jun 11, 2022 · 2 comments
Closed
Labels
ux User experience related

Comments

@pinkfrog9
Copy link

In improving my workflow, I am thinking about ditching the interactive repl pane and use it only when very necessary.

However, one thing annoying when hidding the repl is that, say if I do a calva evaulate current file and if something bad happens, e.g., thrown exception, I can only go to the repl to see what’s going on.

I think if it would be better to also show the output somewhere inside the bottom part of vscode (see figure). Possible? Or any better approach?

Slack thread: https://clojurians.slack.com/archives/CBE668G4R/p1654870103815189

@bpringe bpringe added output/repl window ux User experience related and removed output/repl window labels Jun 16, 2022
@bpringe
Copy link
Member

bpringe commented Jun 16, 2022

I think we could narrow the scope of this to be about errors. Here are some ideas:

a. Show errors somewhere else, including the stack trace
b. Alert the user that there was an error somewhere else, but instruct them to view the error details in the output window, OR open the output window automatically when there is an error.

We could use the Calva says output window for showing errors or for informing the user that there is an error, but the user would either need to have this pane open or we'd have to open it automatically (same problem as with the output window, sort of).

With the above in mind, maybe it's best to indicate a load-file error in the status bar, or with an error popup. The error pop up gives us the ability to explain more in a more convenient way than the status bar, and is more obvious to the user (they might not notice the status bar indicator), plus we can add a button to it to open the output window.

I think @PEZ likes to avoid pop up messages, and I think that's a good idea for something that happens often, but I think if we're just talking about load-file in particular (after all, we can already tell if errors occur when evaluating individual forms in the file), then a pop up message would actually work nicely for this.

@PEZ
Copy link
Collaborator

PEZ commented Jun 16, 2022

I'm leaning towards an error pop-up giving some context and with a button taking you to the output window for more info/stack trace. For all the reasons you mention, @bpringe.

PEZ added a commit that referenced this issue Sep 18, 2022
If output window is not visible

Fixes #1767
@PEZ PEZ mentioned this issue Sep 18, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux User experience related
Projects
None yet
Development

No branches or pull requests

3 participants