Add newline if evaluation is from the prompt

Fixes #1931

CHANGELOG.md

@@ -4,6 +4,8 @@ Changes to Calva.
 
 ## [Unreleased]
 
+- Fix: [Newline lacking before results when evaluating at the REPL prompt](https://github.com/BetterThanTomorrow/calva/issues/1931)
+
 ## [2.0.313] - 2022-10-31
 
 - [Use format-as-you-type for Paredit](https://github.com/BetterThanTomorrow/calva/issues/1924)

src/evaluate.ts

@@ -239,6 +239,12 @@ async function evaluateSelection(document = {}, options) {
         undefined,
         annotations.AnnotationStatus.PENDING
       );
+      if (
+        state.extensionContext.workspaceState.get('outputWindowActive') &&
+        !(await outputWindow.lastLineIsEmpty())
+      ) {
+        outputWindow.appendLine();
+      }
       await evaluateCodeUpdatingUI(
         code,
         { ...options, ns, line, column, filePath, session },

src/results-output/results-doc.ts

@@ -266,10 +266,13 @@ export function appendCurrentTopLevelForm() {
   void appendFormGrabbingSessionAndNS(true);
 }
 
-function lastLineIsEmpty(doc: vscode.TextDocument): boolean {
-  const { lineCount } = doc;
-  const lastLine = doc.getText(new vscode.Range(lineCount - 1, 0, lineCount - 1, Infinity));
-  return lastLine === '';
+export async function lastLineIsEmpty(): Promise<boolean> {
+  try {
+    const doc = await vscode.workspace.openTextDocument(DOC_URI());
+    return util.lastLineIsEmpty(doc);
+  } catch (error) {
+    console.error('Failed opening results doc', error);
+  }
 }
 
 function visibleResultsEditors(): vscode.TextEditor[] {

src/utilities.ts

@@ -547,6 +547,14 @@ function pathExists(path: string): boolean {
   return fs.existsSync(path);
 }
 
+export function lastLineIsEmpty(
+  doc: vscode.TextDocument = vscode.window.activeTextEditor.document
+): boolean {
+  const { lineCount } = doc;
+  const lastLine = doc.getText(new vscode.Range(lineCount - 1, 0, lineCount - 1, Infinity));
+  return lastLine === '';
+}
+
 export {
   distinct,
   getWordAtPosition,