-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ProgramData version detection + Semver Version sorting #150
Conversation
e91d7bb
to
f4d21dc
Compare
Interesting thing |
f4d21dc
to
0726f78
Compare
I reworked the complete PR. Needs some testing on Windows but seems to work correctly on Linux. |
Btw, I wonder when the first person called snap complains that they aren't supported. |
Why is |
Yes, but the purpose of the This is so that when a package gets an update that would break things or make them behave weirdly it won't mess up your build automation because it will use the same versions you used during development and for testing. |
Technically |
0726f78
to
3d415c8
Compare
replaced the package-lock.json and updated yarn lockfile instead |
3d415c8
to
024f1d7
Compare
had to fix it because I accendentially commit some changes that were essentially undoing previous commits |
Fix proposal for #149
It's built on top of #139 so it's also a fix for #138. Which however still didn't explain why a lower version folder was sometimes detected, as there seemed to be a higher version folder detected.
This is also a bigger refactoring in general that also changes the validate functions which the original PR doesn't.
Tested to be working on Windows, but I did have to set it up the folders manually because discord installed itself in the normal appdata directory.