#179 fix path for latest-version v2 kv delete #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current code attempts a DELETE on the metadta path, but Vault expects a DELETE on the data path. From the Vault API docs (https://www.vaultproject.io/api/secret/kv/kv-v2.html#delete-latest-version-of-secret): »Delete Latest Version of Secret This endpoint issues a soft delete of the secret's latest version at the specified location. This marks the version as deleted and will stop it from being returned from reads, but the underlying data will not be removed. A delete can be undone using the undelete path. Method Path DELETE /secret/data/:path
sfc-gh-dkarp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code attempts a DELETE on the
metadatapath to do kv delete of the latest version,but Vault expects a DELETE on the
datapath.From the Vault API docs (https://www.vaultproject.io/api/secret/kv/kv-v2.html#delete-latest-version-of-secret):
»Delete Latest Version of Secret
This endpoint issues a soft delete of the secret's latest version at the specified
location. This marks the version as deleted and will stop it from being returned
from reads, but the underlying data will not be removed. A delete can be undone
using the undelete path.
Method Path
DELETE /secret/data/:path