Code

Overall code health improvements#187

Code

Merged

steve-perkins merged 35 commits intoBetterCloud:masterBetterCloud/vault-java-driver:masterfrom jetersen:chore/overallCodeHealthCopy head branch name to clipboardAug 26, 2019

+848-702

Commits

Commits on Aug 24, 2019

• fix compile encoding issue

  jetersen

  committed
  e11b197

• fix javadoc compile issue

  jetersen

  committed
  6750d9f

• fix testcontainer deprecation and use extend generic container pattern

  jetersen

  committed
  753cb97

• fix up logical tests after #176

  jetersen

  committed
  b62b6f5

• Java 5: unnecessary boxing

  jetersen

  committed
  ffc8839

• Java 5: unnecessary unboxing

  jetersen

  committed
  0f21b6e

• Java 7: explicit type replaced with <>

  jetersen

  committed
  ae2f6e7

• Java 8: anonymous type replaced with method reference

  jetersen

  committed
  00894c2

• Java 8: anonymous type replaced with lambda

  jetersen

  committed
  e301c78

• convert field to local

  jetersen

  committed
  891047b

• suppress deprecation in AppIdTests

  jetersen

  committed
  7f40bec

• fix SslContextFactory deprecation by using SslContextFactory.Server

  jetersen

  committed
  7c14dba

• add checkstyle

  jetersen

  committed
  b9133ee

• fix trailing whitespace

  jetersen

  committed
  de96c0a

• fix final newline

  jetersen

  committed
  1a464c9

Commits on Aug 25, 2019

• add GitHub Action CI

  jetersen

  committed
  8676208

• add Travis CI

  Show description for 67dddfc
  jetersen

  committed
  67dddfc

• Skip testcontainers if Docker is not available

  jetersen

  committed
  3e0eeda

• Use UTF-8 Charset constant

  jetersen

  committed
  ad34a13

• remove redundant private modifier on enum

  jetersen

  committed
  735815b

• pointless comparison of boolean

  jetersen

  committed
  66182c2

• unnecessary null check before equals call

  jetersen

  committed
  eafd359

• Simplify stream chains

  jetersen

  committed
  aaa52b2

• string concatenation used in a string builder 😓

  jetersen

  committed
  a738b4b

• string concatenation in a loop 😓

  jetersen

  committed
  f0f4953

• condition is covered by instanceOf

  jetersen

  committed
  87b6cbb

• unnecessary initialization of StringBuilder

  jetersen

  committed
  ff5f5b6

• simplify clone of ArrayList

  jetersen

  committed
  764219b

• simplify assertNull

  jetersen

  committed
  7f3756f

• Use Integer.valueOf instead

  jetersen

  committed
  50230cd

• info log level for CI

  jetersen

  committed
  e7cae4a

• use in-memory keystore to avoid file locks

  jetersen

  committed
  3128912

• code style and import order

  jetersen

  committed
  a684096

Commits on Aug 26, 2019

• Changed the list() methods to return a LogicalResult so the status code can be checked. Added new method getListData() to LogicalResult

  

  Barry Klawans

  authored and

  jetersen

  committed
  3231da3

• Merge branch 'master' into chore/overallCodeHealth

  jetersen

  authored
  ace3e0f