Add nonce value to AuthResponse #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks @adammead! |
rimitchell
pushed a commit
to rimitchell/vault-java-driver
that referenced
this pull request
Jul 22, 2019
Add nonce value to AuthResponse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to re-authenticate with Vault via AWS, the nonce from the original authentication request needs to be used. The nonce value was not included in AuthResponse; I added it so it can be retrieved to be used in future authentication requests.
Per the vault documentation, this is the response from AWS authentication:
{ "auth": { "renewable": true, "lease_duration": 72000, "metadata": { "role_tag_max_ttl": "0s", "role": "ami-f083709d", "region": "us-east-1", "nonce": "5defbf9e-a8f9-3063-bdfc-54b7a42a1f95", "instance_id": "i-a832f734", "ami_id": "ami-f083709d" }, "policies": [ "default", "dev", "prod" ], "accessor": "5cd96cd1-58b7-2904-5519-75ddf957ec06", "client_token": "150fc858-2402-49c9-56a5-f4b57f2c8ff1" }, "warnings": null, "wrap_info": null, "data": null, "lease_duration": 0, "renewable": false, "lease_id": "", "request_id": "d7d50c06-56b8-37f4-606c-ccdc87a1ee4c" }