Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop lombok & jaxb dependencies & package module-info for JDK9+ #165

Merged
merged 1 commit into from
Jun 3, 2019

Conversation

pjriot
Copy link

@pjriot pjriot commented Mar 29, 2019

Hi, and thanks a lot for the driver!

I'm working on moving an application to JDK9+ and in particular I'm interested in generating jlink images. With a view to this I've created the following pull request that:

  • adds a module-info.class compiled with JDK9 while leaving all other sources as JDK8. This should ensure compatibility when running on either JDK version.
  • replaces the dependency on javax.xml.bind.DatatypeConverter (removed in JDK11) with the java.util.Base64 class added in JDK8. (zero-dependency!)
  • potentially controversially, removes the compile dependency on lombok. (it caused me all kinds of trouble during this exercise, but that may be my own failing)

Let me know if you think this would be useful!

@steve-perkins
Copy link
Contributor

Thanks a lot, @pjriot! I'm really surprised that Lombok was only being used so lightly (it's quite pervasive in most of our internal stuff). I don't have any issue with its removal.

@steve-perkins steve-perkins merged commit a404206 into BetterCloud:master Jun 3, 2019
rimitchell pushed a commit to rimitchell/vault-java-driver that referenced this pull request Jul 22, 2019
Drop lombok & jaxb dependencies & package module-info for JDK9+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants